Fix HistoricalStdlibVersions install to version

[IanButterworth]

Fixes #3929

Given this branch isn't touched on this CI

% julia  
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.10.4 (2024-06-04)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

(@v1.10) pkg> activate --temp
  Activating new project at `/var/folders/1z/jf841bdj73bdj3vk7kc7f_3w0000gn/T/jl_0iHV55`

julia> import Pkg

julia> Pkg.add(name="HistoricalStdlibVersions", version="1.2")
   Resolving package versions...
    Updating `/private/var/folders/1z/jf841bdj73bdj3vk7kc7f_3w0000gn/T/jl_0iHV55/Project.toml`
⌃ [6df8b67a] + HistoricalStdlibVersions v1.2.4
    Updating `/private/var/folders/1z/jf841bdj73bdj3vk7kc7f_3w0000gn/T/jl_0iHV55/Manifest.toml`
⌃ [6df8b67a] + HistoricalStdlibVersions v1.2.4
        Info Packages marked with ⌃ have new versions available and may be upgradable.

julia> 

julia> Pkg.add(name="HistoricalStdlibVersions", version="1.2", io=iob)

julia>

[DilumAluthge]

Can we also take this opportunity to specify the UUID?

[IanButterworth]

Go ahead

[DilumAluthge]

@IanButterworth The backport label for 1.10 has no hyphen, but the backport label for 1.11 does have a hyphen. Is that something we need to fix? Does this break the Backporter script?

[IanButterworth]

Good catch https://github.com/KristofferC/Backporter/blob/f366a87a94c9d38fd107a1c53ccc4550f3687625/backporter.jl#L23

Fixed

[staticfloat]

Maybe we should parse the compat bound from the Project.toml?

[IanButterworth]

I thought about that, but what if we start doing "1.2,2". Part of the problem is this code path isn't hit on Pkg's own CI.

We might just want to teach Base.runtests to run stdlib tests via Pkg.test to handle test deps properly

[DilumAluthge]

Is Pkg.test guaranteed to pick up the correct version of the stdlib? (Because we're not doing the "modify the stdlib UUID trick.)

If we can get Pkg.test("StdlibName") to work correctly in Base.runtests, I agree that's probably the best solution.

[staticfloat]

I thought about that, but what if we start doing "1.2,2".

That's exactly why I want this. Pkg.add(;..., version=VersionSpec(...)) works, so you can do something like the following:

hsv_compat_val = TOML.parsefile(project_path)["compat"]["HistoricalStdlibVersions"]
Pkg.add(;name="HistoricalStdlibVersions", version=Pkg.Types.semver_spec(hsv_compat_val))

[DilumAluthge]

IIRC, we do some shenanigans with the JULIA_PROJECT and JULIA_LOAD_PATH. So we need to make sure that Pkg.test still works correctly in that case.

Also, how will this work with testgroups? For stdlibs, Base.runtests is supposed to look at the test/testgroups file, and run each testgroup in parallel. Would we have to teach Pkg.test to understand stdlib testgroups? I'm not sure if we want to add that kind of functionality as public API in Pkg, but maybe we can add it as a private/internal Pkg API that we only use for stdlib tests in Base.runtests.

[DilumAluthge]

Something like Pkg.test("StdlibName"; _stdlib_testgroup = "desired_test_group") might be sufficient. And we keep _stdlib_testgroup as private/internal API only.