Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more internal Pkg.add api to bypass auto-registry-install #3941

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

Keno
Copy link
Member

@Keno Keno commented Jul 4, 2024

Fixes #3940. HistoryicalStdlibVersions has no dependencies, so the registry should not be required to install it.

Fixes #3940. HistoryicalStdlibVersions has no dependencies, so the registry should not be required to install it.
@IanButterworth
Copy link
Sponsor Member

Might a cleaner way to do this be to git clone HistoryicalStdlibVersions at the right commit then Pkg.dev it?

@IanButterworth
Copy link
Sponsor Member

Even develop installs the default registries if not present https://github.com/IanButterworth/Pkg.jl/blob/aa6e43ff5dbd6e88202b966e9d55221b15825d4e/src/API.jl#L149

So this seems to be the way. Just a little brittle as this code isn't hit in the Pkg repo CI, just julia CI

test/runtests.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth merged commit 6b43949 into master Jul 22, 2024
7 checks passed
@IanButterworth IanButterworth deleted the kf/noregautoinstall branch July 22, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pkg tests puts an outdated copy of General in usr/share/registries
2 participants