Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fixes because Example v0.5.4 and v0.5.5 were registered #4029

Merged
merged 4 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/new.jl
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ end
@test Pkg.dependencies()[exuuid].version == v"0.3.0"
@test Pkg.dependencies()[pngjll_uuid].version == v"1.6.37+4"
Pkg.add(Pkg.PackageSpec(;name="JSON", version="0.18.0"); preserve=Pkg.PRESERVE_NONE)
@test Pkg.dependencies()[exuuid].version == v"0.5.3"
@test Pkg.dependencies()[exuuid].version > v"0.3.0"
@test Pkg.dependencies()[json_uuid].version == v"0.18.0"
@test Pkg.dependencies()[pngjll_uuid].version > v"1.6.37+4"
end
Expand Down
5 changes: 4 additions & 1 deletion test/pkg.jl
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,10 @@ temp_pkg_dir() do project_path
@test_throws PkgError Pkg.develop(Pkg.PackageSpec(url="bleh", rev="blurg"))
Pkg.develop(TEST_PKG.name)
@test isinstalled(TEST_PKG)
@test Pkg.dependencies()[TEST_PKG.uuid].version > old_v
# This test is disabled because it relied on Example.jl having a version
# number in the Project.toml file on master that wasn't released, which
# is no longer true.
# @test Pkg.dependencies()[TEST_PKG.uuid].version > old_v
IanButterworth marked this conversation as resolved.
Show resolved Hide resolved
test_pkg_main_file = joinpath(devdir, TEST_PKG.name, "src", TEST_PKG.name * ".jl")
@test isfile(test_pkg_main_file)
# Pkg #152
Expand Down
5 changes: 4 additions & 1 deletion test/repl.jl
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ temp_pkg_dir(;rm=false) do project_path; cd(project_path) do;

pkg"test Example"
@test isinstalled(TEST_PKG)
@test Pkg.dependencies()[TEST_PKG.uuid].version > v
# This test is disabled because it relied on Example.jl having a version
# number in the Project.toml file on master that wasn't released, which
# is no longer true.
# @test Pkg.dependencies()[TEST_PKG.uuid].version > v

pkg2 = "UnregisteredWithProject"
pkg2_uuid = UUID("58262bb0-2073-11e8-3727-4fe182c12249")
Expand Down
Loading