Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of a url and subdir in [sources] #4039

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

tecosaur
Copy link
Contributor

@tecosaur tecosaur commented Oct 7, 2024

Monorepos exist, so we shouldn't complain when somebody tries to combine the url and subdir parameters.

I think this is all that's needed to close #4026. These additions are just from looking through #3783 for suspicious omissions.

@KristofferC
Copy link
Member

This might be all that is needed but would be good with a test to confirm.

@tecosaur
Copy link
Contributor Author

tecosaur commented Oct 7, 2024

I notice in the tests in test/sources.jl https://github.com/JuliaLang/Example.jl is used, and that actually exists. Is https://github.com/JuliaLang/ExampleMonorepo.jl needed or similar?

@fatteneder
Copy link
Member

duplicate of #3826?

@tecosaur
Copy link
Contributor Author

Huh, looks a bit like it. I assumed no fix was around from the state of #4026.

@IanButterworth IanButterworth mentioned this pull request Oct 20, 2024
3 tasks
@tecosaur
Copy link
Contributor Author

It would be good to get a fix into 1.11.2 if possible. If sorting out the test is the main blocker, can't we grab this for now and add a test later: it's not like it will make the current situation (not working at all) any worse.

#3826 also includes this fix, but it's marked as WIP.

@IanButterworth
Copy link
Member

I don't think we should merge without tests of some sort.
Note that there are packages in test/test_packages. Can a test package just be added there?

The docs also need updating https://pkgdocs.julialang.org/dev/toml-files/#The-[sources]-section

@tecosaur
Copy link
Contributor Author

That's an idea, I'll try using something from the test_packages folder and push something tonight.

Monorepos exist, so we shouldn't complain when somebody tries to combine
the url and subdir parameters.
@tecosaur
Copy link
Contributor Author

tecosaur commented Dec 2, 2024

Well, that was an awful time estimate. Arguably I'm spinning too many plates, but there's now a test and a docs update. I think that should do it?

@KristofferC
Copy link
Member

Excellent, thank you!

@KristofferC KristofferC merged commit d84a1a3 into JuliaLang:master Dec 3, 2024
7 checks passed
KristofferC pushed a commit that referenced this pull request Dec 13, 2024
@KristofferC KristofferC mentioned this pull request Dec 13, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sources section of Project.toml does not support subdir
4 participants