better info messages for activating new env #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
much better |
KristofferC
reviewed
Aug 11, 2018
src/API.jl
Outdated
| @@ -611,7 +611,7 @@ function activate(path::String; shared::Bool=false) | |||
| # unless the shared environment already exists, place it in the first depots | |||
| if !isdir(fullpath) | |||
| fullpath = joinpath(Pkg.envdir(Pkg.depots1()), path) | |||
| @info("new shared environment \"$path\" will be placed at $fullpath") | |||
| @info("activating new shared environment \"$path\" at $fullpath.") | |||
There was a problem hiding this comment.
Even though we use --shared I don't think we should call it shared environment. It's just a normal environment, no?
|
Looks like CI need to be fixed. |
|
Oh yea, I added tests for the log messages, which will need to be updated |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 13, 2018
618: better info messages for activating new env r=fredrikekre a=fredrikekre 631: stop testing on 0.7 r=KristofferC a=KristofferC No point 634: fix gc in prescence of normal files r=KristofferC a=KristofferC Fixes #601 Co-authored-by: Fredrik Ekre <fredrik.ekre@chalmers.se> Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Canceled (will resume) |
|
bors r- |
Canceled |
|
bors r+ |
Timed out (retrying...) |
|
bors r- |
Canceled |
|
bors r+ |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.