Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg REPL: sort commands within each super-spec #986

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Pkg REPL: sort commands within each super-spec #986

merged 1 commit into from
Jan 11, 2019
+7 −7

Conversation

fredrikekre
Copy link
Member

Sort commands within each super-spec instead of globally when displaying help.

This will display:

activate
[...]
update
registry-add
[...]
registry-update

instead of

activate
[...]
preview
registry-add
[...]
registry-update
remove
[...]
update

i.e. group all package commands together first, and then all registry commands.

bors try

bors bot added a commit that referenced this pull request Jan 11, 2019
@bors
Try #986:
17ab06f
@fredrikekre
Pkg REPL: sort commands within each super-spec
8cabd59 
instead of globally when displaying help.
@fredrikekre
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented Jan 11, 2019

try

Not awaiting review

@bors
Copy link
Contributor

bors bot commented Jan 11, 2019

try

Build failed

@fredrikekre
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 11, 2019
@bors
Try #986:
be3771a
@bors
Copy link
Contributor

bors bot commented Jan 11, 2019

try

Build succeeded

00vareladavid
00vareladavid approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@00vareladavid 00vareladavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this is a lot nicer.

@fredrikekre
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Jan 11, 2019
@bors @fredrikekre
Merge #986
d480435 
986: Pkg REPL: sort commands within each super-spec r=fredrikekre a=fredrikekre

Sort commands within each super-spec instead of globally when displaying help.



Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 11, 2019

Build succeeded

@bors bors bot merged commit 8cabd59 into master Jan 11, 2019
@bors bors bot deleted the fe/help-sort branch January 11, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@00vareladavid 00vareladavid 00vareladavid approved these changes

Assignees
No one assigned
Labels
REPL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @00vareladavid