Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #101 again #142

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Fix #101 again #142

merged 2 commits into from
Apr 24, 2018

Conversation

simonbyrne
Copy link
Contributor

@simonbyrne simonbyrne commented Apr 23, 2018

#141 made some changes, however I forgot that content has different error handling behaviour than cat. This is a bit of a kludge, but hopefully should fix #101 again.

#141 made some changes, however I forgot that `content` has different error handling behaviour than `cat`. This is a bit of a kludge, but hopefully should work.
@codecov-io
Copy link

codecov-io commented Apr 23, 2018

Codecov Report

Merging #142 into master will decrease coverage by 0.37%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   46.21%   45.84%   -0.38%     
==========================================
  Files           6        6              
  Lines         489      493       +4     
==========================================
  Hits          226      226              
- Misses        263      267       +4
Impacted Files Coverage Δ
src/entry.jl 47.53% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c648209...a554ee8. Read the comment docs.

if old != sha1
throw(Pkg.PkgError("$pkg v$ver SHA1 changed in METADATA – refusing to publish"))
end
catch e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is exactly what I meant by

we should avoid needing try catches everywhere if the new api is going to throw in a bunch of expected situations

is there an error code or anything? this will silently swallow all GitErrors, including unexpected ones that should still be fatal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but this is basically duct tape at this stage. I've tweaked this a bit to be more specific.

@simonbyrne simonbyrne merged commit 2082d43 into master Apr 24, 2018
@simonbyrne simonbyrne deleted the sb/fixcat branch April 24, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.6: ERROR: GitError(Code:ENOTFOUND, Class:Tree, the path '0.1.0' does not exist in the given tree)
4 participants