Handle missing values in clamp

JuliaLang · Feb 14, 2019 · 0513b19 · 0513b19
1 parent 111b385
commit 0513b19
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -38,6 +38,7 @@ Standard library changes
 * `hasmethod` can now check for matching keyword argument names ([#30712]).
 * `startswith` and `endswith` now accept a `Regex` for the second argument ([#29790]).
 * `retry` supports arbitrary callable objects ([#30382]).
+* `clamp` can now handle missing values ([#31066]).
 
 #### LinearAlgebra
 

diff --git a/base/math.jl b/base/math.jl
@@ -1070,5 +1070,6 @@ for f in (:(acos), :(acosh), :(asin), :(asinh), :(atan), :(atanh),
           :(log2), :(exponent), :(sqrt))
     @eval $(f)(::Missing) = missing
 end
+clamp(::Missing, lo, hi) = missing
 
 end # module
diff --git a/test/missing.jl b/test/missing.jl
@@ -163,6 +163,8 @@ Base.one(::Type{Unit}) = 1
         @test ismissing(f(missing))
     end
 
+    @test ismissing(clamp(missing, 1, 2))
+
     for T in (Int, Float64)
         @test zero(Union{T, Missing}) === T(0)
         @test one(Union{T, Missing}) === T(1)