-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ export | |
LinAlg, | ||
BLAS, | ||
LAPACK, | ||
SparseMatrix, | ||
Docs, | ||
Markdown, | ||
|
||
|
@@ -904,6 +905,7 @@ export | |
searchindex, | ||
show, | ||
showall, | ||
showarray, | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ivarne
Member
|
||
showcompact, | ||
showerror, | ||
split, | ||
|
3 comments
on commit 07f3ee7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right fix! It shouldn't be necessary to add new Base exports in order to make code inside Base work! Ideally, sparse.jl should not contain importall Base
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SparseMatrix
really should have been exported like all the other things. Not sure why that was missing. showarray
also seemed like a useful thing to export, for those implementing new array types outside Base.
I do agree that otherwise this is not a good fix, but I just wanted to fix the regression first. I also do want to get rid of the importall Base
in sparse.jl, which was a mental note I made when looking into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mental notes would be good to record as comments...
If we export
showarray
we should probably document it.