Apply suggestions from code review

Co-authored-by: Jameson Nash <vtjnash@gmail.com>
JuliaLang · Jul 25, 2021 · 0aab0dc · 0aab0dc
1 parent b215082
commit 0aab0dc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/stdlib/REPL/src/REPL.jl b/stdlib/REPL/src/REPL.jl
@@ -472,7 +472,7 @@ LineEditREPL(t::TextTerminal, hascolor::Bool, envcolors::Bool=false) =
     )
 
 mutable struct REPLCompletionProvider <: CompletionProvider
-    modifier::Symbol
+    shift::Bool
 end
 REPLCompletionProvider() = REPLCompletionProvider(:none)
 mutable struct ShellCompletionProvider <: CompletionProvider end

diff --git a/stdlib/REPL/src/REPLCompletions.jl b/stdlib/REPL/src/REPLCompletions.jl
@@ -504,16 +504,16 @@ function complete_any_methods(ex_org::Expr, callee_module::Module, context_modul
     end
 
     for name in names(callee_module; all=true)
-        if isdefined(callee_module, name)
+        if !isdeprecated(callee_module, name) && isdefined(callee_module, name)
             func = getfield(callee_module, name)
-            if isa(func, Base.Callable) && func !== Vararg
+            if !isa(func, Module)
                 complete_methods!(out, func, args_ex, kwargs_ex, moreargs)
             elseif callee_module === Main::Module && isa(func, Module)
                 callee_module2 = func
                 for name in names(callee_module2)
                     if isdefined(callee_module2, name)
                         func = getfield(callee_module, name)
-                        if isa(func, Base.Callable) && func !== Vararg
+                        if isa(func, Base.Callable)
                             complete_methods!(out, func, args_ex, kwargs_ex, moreargs)
                         end
                     end