Merge pull request #17404 from Sacha0/reworksetindex

Make setindex! for sparse matrices and vectors not purge stored entries on zero assignment
JuliaLang · Jul 19, 2016 · 3647de6 · 3647de6
2 parents c2e3494 + 59d3d7c
commit 3647de6
Show file tree

Hide file tree

Showing 5 changed files with 378 additions and 148 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -201,6 +201,10 @@ Library improvements
     * All `sparse` methods now retain provided numerical zeros as structural nonzeros; to
       drop numerical zeros, use `dropzeros!` ([#14798], [#15242]).
 
+    * `setindex!` methods for sparse matrices and vectors no longer purge allocated entries
+      on zero assignment. To drop stored entries from sparse matrices and vectors, use
+      `Base.SparseArrays.dropstored!` ([#17404]).
+
   * New `foreach` function for calling a function on every element of a collection when
     the results are not needed ([#13774]).
 
@@ -350,3 +354,4 @@ Deprecated or removed
 [#17374]: https://github.com/JuliaLang/julia/issues/17374
 [#17393]: https://github.com/JuliaLang/julia/issues/17393
 [#17402]: https://github.com/JuliaLang/julia/issues/17402
+[#17404]: https://github.com/JuliaLang/julia/issues/17404