Use generic fallback for arrays with !(eltype >: Missing)

JuliaLang · Jul 5, 2018 · 3b88f3c · 3b88f3c
1 parent e19f39c
commit 3b88f3c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/base/missing.jl b/base/missing.jl
@@ -190,7 +190,10 @@ function iterate(itr::SkipMissing, state...)
 end
 
 # Optimized mapreduce implementation
-mapreduce(f, op, itr::SkipMissing{<:AbstractArray}) = _mapreduce(f, op, IndexStyle(itr.x), itr)
+# The generic method is faster when !(eltype(A) >: Missing) since it does not need
+# additional loops to identify the two first non-missing values of each block
+mapreduce(f, op, itr::SkipMissing{<:AbstractArray}) =
+    _mapreduce(f, op, IndexStyle(itr.x), eltype(itr.x) >: Missing ? itr : itr.x)
 
 function _mapreduce(f, op, ::IndexLinear, itr::SkipMissing{<:AbstractArray})
     A = itr.x