Skip to content

Commit

Permalink
Added test for Base.propertynames of hessenberg (#34983)
Browse files Browse the repository at this point in the history
  • Loading branch information
dkarrasch authored Mar 5, 2020
1 parent 71d9375 commit 4d9a334
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions stdlib/LinearAlgebra/test/hessenberg.jl
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,10 @@ let A = [0.5 0.1 0.9 0.4; 0.9 0.7 0.5 0.4; 0.3 0.4 0.9 0.0; 0.4 0.0 0.0 0.5]
@test logdet(hessenberg(A)) logdet(A) -3.5065578973199822
end

@testset "Base.propertynames" begin
F = hessenberg([4. 9. 7.; 4. 4. 1.; 4. 3. 2.])
@test Base.propertynames(F) == (:Q, :H, )
@test Base.propertynames(F, true) == (:Q, :H, , , :factors, :uplo)
end

end # module TestHessenberg

2 comments on commit 4d9a334

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.