Keep parametric information when constructing a SparseMatrixCSC from …

…a SparseMatrixCSC. (#28642)
JuliaLang · Aug 14, 2018 · 686ffdb · 686ffdb
1 parent 3d8091f
commit 686ffdb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/stdlib/SparseArrays/src/sparsematrix.jl b/stdlib/SparseArrays/src/sparsematrix.jl
@@ -356,6 +356,7 @@ similar(S::SparseMatrixCSC, ::Type{TvNew}, ::Type{TiNew}, m::Integer, n::Integer
 
 
 # converting between SparseMatrixCSC types
+SparseMatrixCSC(S::SparseMatrixCSC) = copy(S)
 AbstractMatrix{Tv}(A::SparseMatrixCSC) where {Tv} = SparseMatrixCSC{Tv}(A)
 SparseMatrixCSC{Tv}(S::SparseMatrixCSC{Tv}) where {Tv} = copy(S)
 SparseMatrixCSC{Tv}(S::SparseMatrixCSC) where {Tv} = SparseMatrixCSC{Tv,eltype(S.colptr)}(S)

diff --git a/stdlib/SparseArrays/test/sparse.jl b/stdlib/SparseArrays/test/sparse.jl
@@ -2289,4 +2289,10 @@ end
     @test adjoint(MC) == copy(adjoint(SC))
 end
 
+@testset "Issue #28634" begin
+    a = SparseMatrixCSC{Int8, Int16}([1 2; 3 4])
+    na = SparseMatrixCSC(a)
+    @test typeof(a) === typeof(na)
+end
+
 end # module