Skip to content

Commit

Permalink
Add (broken) tests for allocation in 5-arg mul!() (#49210)
Browse files Browse the repository at this point in the history
  • Loading branch information
@amilsted
amilsted authored Jun 14, 2023
1 parent df09f67 commit 834aad4
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions stdlib/LinearAlgebra/test/matmul.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -979,4 +979,17 @@ end
end
end

@testset "Issue #46865: mul!() with non-const alpha, beta" begin
f!(C,A,B,alphas,betas) = mul!(C, A, B, alphas[1], betas[1])
alphas = [1.0]
betas = [0.5]
for d in [2,3,4] # test native small-matrix cases as well as BLAS
A = rand(d,d)
B = copy(A)
C = copy(A)
f!(C, A, B, alphas, betas)
@test_broken (@allocated f!(C, A, B, alphas, betas)) == 0
end
end

end # module TestMatmul

4 comments on commit 834aad4

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected.
A full report can be found here.

@aviatesk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks("inference", vs="@e1c0d83692accffcc63191233f7f9dd758c23f1b")

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - no performance regressions were detected. A full report can be found here.

Please sign in to comment.