Skip to content

Commit

Permalink
Stop exporting dot from LinearAlgebra.BLAS (#31878)
Browse files Browse the repository at this point in the history
LinearAlgebra exports the familiar `dot` function. The BLAS submodule
has its own `dot` function, which it also exports, leading to problems
if a user tries to access `dot` after `using` both LinearAlgebra and
BLAS.

Because this conflict currently exists, this change should be
non-breaking, as it's difficult to resolve `dot` unqualified from BLAS
before it's resolved from LinearAlgebra, so pretty much any consumer
must already calling `BLAS.dot` as such.

Fixes #31838.
  • Loading branch information
ararslan authored Apr 30, 2019
1 parent ffef661 commit 8cc2f12
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Standard library changes

#### LinearAlgebra

* The BLAS submodule no longer exports `dot`, which conflicts with that in LinearAlgebra ([#31838]).
* `diagm` and `spdiagm` now accept optional `m,n` initial arguments to specify a size ([#31654]).

#### SparseArrays
Expand Down
1 change: 0 additions & 1 deletion stdlib/LinearAlgebra/src/blas.jl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ export
axpy!,
axpby!,
blascopy!,
dot,
dotc,
dotu,
scal!,
Expand Down

0 comments on commit 8cc2f12

Please sign in to comment.