Skip to content

Commit

Permalink
add a GC safepoint in Task.wait (#41441)
Browse files Browse the repository at this point in the history
  • Loading branch information
@vilterp
vilterp authored Jul 7, 2021
1 parent 480ff81 commit 97f817a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions base/task.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,7 @@ end
end

function wait()
GC.safepoint()
W = Workqueues[Threads.threadid()]
poptask(W)
result = try_yieldto(ensure_rescheduled)
Expand Down

4 comments on commit 97f817a

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@vtjnash
Copy link
Member

@vtjnash vtjnash commented on 97f817a Jul 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @christopher-dG

Please sign in to comment.