Fix and test PCRE error message getter. (#35728)

JuliaLang · May 5, 2020 · 9c2492e · 9c2492e
1 parent 6b53e02
commit 9c2492e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/base/pcre.jl b/base/pcre.jl
@@ -147,7 +147,7 @@ free_match_context(context) =
 function err_message(errno)
     buffer = Vector{UInt8}(undef, 256)
     ccall((:pcre2_get_error_message_8, PCRE_LIB), Cvoid,
-          (Int32, Ptr{UInt8}, Csize_t), errno, buffer, sizeof(buffer))
+          (UInt32, Ptr{UInt8}, Csize_t), errno, buffer, sizeof(buffer))
     GC.@preserve buffer unsafe_string(pointer(buffer))
 end
 

diff --git a/test/regex.jl b/test/regex.jl
@@ -139,4 +139,7 @@
     # Test that PCRE throws the correct kind of error
     # TODO: Uncomment this once the corresponding change has propagated to CI
     #@test_throws ErrorException Base.PCRE.info(C_NULL, Base.PCRE.INFO_NAMECOUNT, UInt32)
+
+    # test that we can get the error message of negative error codes
+    @test Base.PCRE.err_message(Base.PCRE.ERROR_NOMEMORY) isa String
 end