Relax a couple of REPL signatures (#37998)

Fixes #37765 and PyPlot docs
JuliaLang · Oct 13, 2020 · a1da84c · a1da84c · nanosoldier · Oct 14, 2020
1 parent c91a750
commit a1da84c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/stdlib/REPL/src/REPL.jl b/stdlib/REPL/src/REPL.jl
@@ -447,9 +447,9 @@ function complete_line(c::ShellCompletionProvider, s::PromptState)
     return unique!(map(completion_text, ret)), partial[range], should_complete
 end
 
-function complete_line(c::LatexCompletions, s::PromptState)
+function complete_line(c::LatexCompletions, s)
     partial = beforecursor(LineEdit.buffer(s))
-    full = LineEdit.input_string(s)
+    full = LineEdit.input_string(s)::String
     ret, range, should_complete = bslash_completions(full, lastindex(partial))[2]
     return unique!(map(completion_text, ret)), partial[range], should_complete
 end

diff --git a/stdlib/REPL/src/docview.jl b/stdlib/REPL/src/docview.jl
@@ -69,10 +69,11 @@ end
 _helpmode(line::AbstractString) = _helpmode(stdout, line)
 
 # Print vertical lines along each docstring if there are multiple docs
-function insert_hlines(io::IO, docs::Markdown.MD)
+function insert_hlines(io::IO, docs)
     if !isa(docs, Markdown.MD) || !haskey(docs.meta, :results) || isempty(docs.meta[:results])
         return docs
     end
+    docs = docs::Markdown.MD
     v = Any[]
     for (n, doc) in enumerate(docs.content)
         push!(v, doc)

diff --git a/stdlib/REPL/test/docview.jl b/stdlib/REPL/test/docview.jl
@@ -2,6 +2,7 @@
 
 using Test
 import REPL
+import Markdown
 
 @testset "symbol completion" begin
     @test startswith(let buf = IOBuffer()
@@ -14,3 +15,7 @@ import REPL
             String(take!(buf))
         end, "\"🐨\" can be typed by \\:koala:<tab>\n")
 end
+
+@testset "Non-Markdown" begin
+    @test isa(REPL.insert_hlines(IOBuffer(), Markdown.Text("foo")), Markdown.Text)
+end