Skip to content

Commit

Permalink
Merge pull request #39065 from fingolfin/mh/jl_new_task-stack-alloc
Browse files Browse the repository at this point in the history
Fix jl_new_task to avoid allocating stack twice
  • Loading branch information
vchuravy authored Jan 22, 2021
2 parents 770d0d5 + d4119a2 commit ae53238
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/task.c
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,7 @@ JL_DLLEXPORT jl_task_t *jl_new_task(jl_function_t *start, jl_value_t *completion
else {
t->bufsz = JL_STACK_SIZE;
}
t->stkbuf = NULL;
}
else {
// user requested dedicated stack of a certain size
Expand All @@ -704,7 +705,6 @@ JL_DLLEXPORT jl_task_t *jl_new_task(jl_function_t *start, jl_value_t *completion
t->sticky = 1;
t->gcstack = NULL;
t->excstack = NULL;
t->stkbuf = NULL;
t->started = 0;
t->prio = -1;
t->tid = -1;
Expand Down

4 comments on commit ae53238

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong when running your job:

ProcessExitedException(3)

cc @christopher-dG

Please sign in to comment.