Skip to content

Commit

Permalink
Move thread name after ptls field to avoid changing offsets (#51353)
Browse files Browse the repository at this point in the history 
Makes it a bit easier to recompile with Tracy, the sysimg stays valid
since we don't change the offset of the ptls field.
  • Loading branch information
@vchuravy
vchuravy authored Sep 18, 2023
1 parent 893fecc commit b189bed
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/julia.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2052,9 +2052,6 @@ typedef struct _jl_task_t {

// hidden state:

#ifdef USE_TRACY
const char *name;
#endif
// id of owning thread - does not need to be defined until the task runs
_Atomic(int16_t) tid;
// threadpool id
Expand All @@ -2072,6 +2069,9 @@ typedef struct _jl_task_t {
size_t world_age;
// quick lookup for current ptls
jl_ptls_t ptls; // == jl_all_tls_states[tid]
#ifdef USE_TRACY
const char *name;
#endif
// saved exception stack
jl_excstack_t *excstack;
// current exception handler
Expand Down

4 comments on commit b189bed

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@vtjnash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Please sign in to comment.