fix #38386, macro defining empty function with escaped name (#38402)

JuliaLang · Jan 22, 2021 · d179f48 · d179f48
1 parent 24a4637
commit d179f48
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/macroexpand.scm b/src/macroexpand.scm
@@ -383,7 +383,7 @@
                  ,(resolve-expansion-vars-with-new-env (caddr e) env m parent-scope inarg)))
 
            ((= function)
-            (if (and (pair? (cadr e)) (function-def? e))
+            (if (and (pair? (cadr e)) (function-def? e) (length> e 2))
                 ;; in (kw x 1) inside an arglist, the x isn't actually a kwarg
                 `(,(car e) ,(resolve-in-function-lhs (cadr e) env m parent-scope inarg)
                   ,(resolve-expansion-vars-with-new-env (caddr e) env m parent-scope inarg))

diff --git a/test/syntax.jl b/test/syntax.jl
@@ -2324,3 +2324,11 @@ end
 
     @test (Int .<: [Integer] .<: [Real]) == [true]
 end
+
+# issue #38386
+macro m38386()
+    fname = :f38386
+    :(function $(esc(fname)) end)
+end
+@m38386
+@test isempty(methods(f38386))