Add generic fill method accepting return type as argument

JuliaLang · Jun 13, 2016 · deae75b · deae75b
1 parent c574b4d
commit deae75b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/base/abstractarray.jl b/base/abstractarray.jl
@@ -379,6 +379,8 @@ this is equivalent to `collect(a)`.
 """
 copymutable
 
+fill{T<:AbstractArray}(::Type{T}, v, dims::Dims) = fill!(fixate_eltype(T, typeof(v))(dims), v)
+
 zero{T}(x::AbstractArray{T}) = fill!(similar(x), zero(T))
 
 ## iteration support for arrays by iterating over `eachindex` in the array ##

diff --git a/base/array.jl b/base/array.jl
@@ -160,8 +160,8 @@ function fill!{T<:Union{Integer,AbstractFloat}}(a::Array{T}, x)
     return a
 end
 
-fill(v, dims::Dims)       = fill!(Array{typeof(v)}(dims), v)
-fill(v, dims::Integer...) = fill!(Array{typeof(v)}(dims...), v)
+fill(v, dims::Dims)       = fill(Array, v, dims)
+fill(v, dims::Integer...) = fill(Array, v, convert(Dims, dims))
 
 for (fname, felt) in ((:zeros,:zero), (:ones,:one))
     @eval begin