Check arguments in wrapper for xheevr. Add tests for errors reported in

#8057 and #8058
JuliaLang · Aug 19, 2014 · e03700a · e03700a
1 parent 64e21a3
commit e03700a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/base/linalg/lapack.jl b/base/linalg/lapack.jl
@@ -2985,6 +2985,12 @@ for (syev, syevr, sygvd, elty, relty) in
         function syevr!(jobz::BlasChar, range::BlasChar, uplo::BlasChar, A::StridedMatrix{$elty}, vl::FloatingPoint, vu::FloatingPoint, il::Integer, iu::Integer, abstol::FloatingPoint)
             chkstride1(A)
             n = chksquare(A)
+            if range == 'I'
+                1 <= il <= iu <= n || throw(ArgumentError("illegal choise of eigenvalue indices"))
+            end
+            if range == 'V' 
+                vl < vu || throw(ArgumentError("lower boundary must be less than upper boundary"))
+            end
             lda = max(1,stride(A,2))
             m = Array(BlasInt, 1)
             w = similar(A, $relty, n)

diff --git a/test/linalg4.jl b/test/linalg4.jl
@@ -354,3 +354,11 @@ A7933 = [1 2; 3 4]
 B7933 = copy(A7933)
 C7933 = full(Symmetric(A7933))
 @test A7933 == B7933
+
+# Issues #8057 and #8058
+for f in (eigfact, eigvals)
+    for A in (Symmetric(randn(2,2)), Hermitian(complex(randn(2,2), randn(2,2))))
+        @test_throws ArgumentError f(A, 3, 2)
+        @test_throws ArgumentError f(A, 1:4)
+    end
+end