Skip to content

Commit

Permalink
Fix last startup & shutdown precompiles (#51557)
Browse files Browse the repository at this point in the history
  • Loading branch information
@IanButterworth
IanButterworth authored Oct 3, 2023
1 parent a988992 commit f2d1276
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 6 additions & 0 deletions contrib/generate_precompile.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ precompile(isequal, (String, String))
precompile(Base.check_open, (Base.TTY,))
precompile(Base.getproperty, (Base.TTY, Symbol))
precompile(write, (Base.TTY, String))
precompile(Tuple{typeof(Base.get), Base.TTY, Symbol, Bool})
precompile(Tuple{typeof(Base.hashindex), String, Int64})
precompile(Tuple{typeof(Base.write), Base.GenericIOBuffer{Array{UInt8, 1}}, String})
precompile(Tuple{typeof(Base.indexed_iterate), Tuple{Nothing, Int64}, Int64})
precompile(Tuple{typeof(Base.indexed_iterate), Tuple{Nothing, Int64}, Int64, Int64})
# used by Revise.jl
precompile(Tuple{typeof(Base.parse_cache_header), String})
Expand All @@ -57,6 +62,7 @@ precompile(Tuple{typeof(delete!), Dict{Base.PkgId,Vector{Function}}, Base.PkgId}
precompile(Tuple{typeof(push!), Vector{Function}, Function})
# miscellaneous
precompile(Tuple{typeof(Base.exit)})
precompile(Tuple{typeof(Base.require), Base.PkgId})
precompile(Tuple{typeof(Base.recursive_prefs_merge), Base.Dict{String, Any}})
precompile(Tuple{typeof(Base.recursive_prefs_merge), Base.Dict{String, Any}, Base.Dict{String, Any}, Vararg{Base.Dict{String, Any}}})
Expand Down
3 changes: 2 additions & 1 deletion stdlib/REPL/src/precompile.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const PARALLEL_PRECOMPILATION = true
const debug_output = devnull # or stdout

CTRL_C = '\x03'
CTRL_D = '\x04'
CTRL_R = '\x12'
UP_ARROW = "\e[A"
DOWN_ARROW = "\e[B"
Expand Down Expand Up @@ -130,7 +131,7 @@ generate_precompile_statements() = try
sleep(0.1)
end
end
write(ptm, "exit()\n")
write(ptm, "$CTRL_D")
wait(tee)
success(p) || Base.pipeline_error(p)
close(ptm)
Expand Down

5 comments on commit f2d1276

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@vtjnash
Copy link
Member

@vtjnash vtjnash commented on f2d1276 Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here.

@vtjnash
Copy link
Member

@vtjnash vtjnash commented on f2d1276 Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like inference sped back up here. Not sure why that performance is unstable now

But there is still this apparent regression

["broadcast", "mix_scalar_tuple", (5, "scal_tup")] | 3.16 (5%) ❌ | 1.00 (1%)
-- | -- | --
["broadcast", "mix_scalar_tuple", (5, "scal_tup_x3")] | 2.82 (5%) ❌ | 1.00 (1%)
["broadcast", "mix_scalar_tuple", (5, "tup_tup")] | 6.39 (5%) ❌ | 1.00 (1%)

Please sign in to comment.