Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitVector shifts don't accept negative counts #16706

Closed
eschnett opened this issue Jun 1, 2016 · 4 comments
Closed

BitVector shifts don't accept negative counts #16706

eschnett opened this issue Jun 1, 2016 · 4 comments
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@eschnett
Copy link
Contributor

eschnett commented Jun 1, 2016

Arithmetic shifts accept negative shift counts, and then shift in the opposite direction. BitVector does not yet do this.

The standard implementation would be to change the count argument in the current implementation from Int to UInt, and have an additional selector function that accepts Int and chooses the shift direction.

@StefanKarpinski StefanKarpinski added the help wanted Indicates that a maintainer wants help on an issue or pull request label Jun 1, 2016
@sg1101
Copy link

sg1101 commented Feb 24, 2017

Hi @eschnett . I would like to try and solve this issue. I am new to open source and had not contributed yet. I can really use some guidience from you about how to proceed. Thank You :)

@StefanKarpinski
Copy link
Sponsor Member

Unless I'm mistaken, this was fixed by #19760.

@tkelman
Copy link
Contributor

tkelman commented Feb 24, 2017

they could still use docs though

@StefanKarpinski
Copy link
Sponsor Member

Agreed, but that is a different issue.

@StefanKarpinski StefanKarpinski added docs This change adds or pertains to documentation and removed docs This change adds or pertains to documentation labels Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

No branches or pull requests

5 participants