Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bitarray to handle shifts by a negative value. #19760

Merged
merged 1 commit into from
Jan 2, 2017

Conversation

StefanKarpinski
Copy link
Sponsor Member

Rebased and fixed conflicts here: #18154

@tkelman
Copy link
Contributor

tkelman commented Dec 29, 2016

@nanosoldier runbenchmarks(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@tkelman
Copy link
Contributor

tkelman commented Dec 29, 2016

there is the doc issue @rfourquet mentioned, opened as #19767 if you don't want to get it now

@StefanKarpinski
Copy link
Sponsor Member Author

Any clue what the deal with the failed AppVeyor run is? Seems random and unrelated.

@StefanKarpinski
Copy link
Sponsor Member Author

There are a handful of apparent regressions (and one progression), but most of them seem to be unrelated and just noise, with the exception of the nullable arrays regression, which could be real and is fairly significant – 50% slow down.

@tkelman
Copy link
Contributor

tkelman commented Dec 30, 2016

appveyor failure looks like #16555

@StefanKarpinski StefanKarpinski added this to the 0.6.0 milestone Dec 30, 2016
@StefanKarpinski
Copy link
Sponsor Member Author

How about I merge this and open a performance issue for the one regression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants