libuv failing build on 32-bit Centos 5 system

[kmsquire]

~/src/julia32/deps/libuv$ make
cc --std=c89 -pedantic -Wall -Wextra -Wno-unused-parameter -D_GNU_SOURCE -Iinclude -Iinclude/uv-private -Isrc -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -c src/unix/async.c -o src/unix/async.o
In file included from src/unix/internal.h:37,
                 from src/unix/async.c:22:
src/unix/linux/syscalls.h:74: error: expected specifier-qualifier-list before ‘__u64’
make: *** [src/unix/async.o] Error 1

This actually happened with (I think) the last libuv update in julia, with (julia) commit a6e75e3, corresponding to libuv commit 0709538fecef54c67c84d446af7edddd3e4a1e99.

[kmsquire]

Is it better to report these here, or on JuliaLang/libuv?

[kmsquire]

More information: seems to be some commit upstream between node-v0.8.11 and node-v0.9.0

[kmsquire]

The culprit is joyent/libuv@f91e6be. The immediate error is fixed by removing --std=c89. I'm unsure how to do this... @nolta, do you know?

[kmsquire]

Okay, never mind, found it by grepping.

[StefanKarpinski]

Epic self-conversation, but good work :-)

[kmsquire]

I've submitted JuliaLang/libuv#3 (which simply removes "--std=c89" from the libuv build). I'm not sure, though, if that is there for a reason. I can submit upstream to see what they say, instead--let me know. CC: @loladiro @vtjnash

[kmsquire]

(* embarassed laugh ensues... *)

[vtjnash]

Can you please check to see if this happens building from the most recent upstream sources from Joyent?

[kmsquire]

Yep. That's actually how I determined which upstream branch (by manual bisection---I really should figure out how to use git bisect).

~/src/julia32/deps/libuv$ git remote -v | grep upstream
upstream    https://github.com/joyent/libuv (fetch)
upstream    https://github.com/joyent/libuv (push)
~/src/julia32/deps/libuv$ git fetch upstream
~/src/julia32/deps/libuv$ git status
# On branch upstream-master
nothing to commit, working directory clean
~/src/julia32/deps/libuv$ git diff upstream/master
~/src/julia32/deps/libuv$ CC=gcc44 make
gcc44 --std=c89 -pedantic -Wall -Wextra -Wno-unused-parameter -D_GNU_SOURCE -Iinclude -Iinclude/uv-private -Isrc -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -g -c src/unix/async.c -o src/unix/async.o
In file included from src/unix/internal.h:37,
                 from src/unix/async.c:22:
src/unix/linux/syscalls.h:74: error: expected specifier-qualifier-list before ‘__u64’
make: *** [src/unix/async.o] Error 1

[pao]

git bisect is really easy!

# assume things aren't working now...
git bisect bad
# find a known good spot
git checkout XXXXX
run_tests
# tests passed? then...
git bisect good
# magic happens
run_tests
# ...

Then keep running either git bisect good or get bisect bad followed by the test; if the test returns a standard POSIX error code, you can use git bisect run run_tests and it will mark the commits good and bad automatically.

[kmsquire]

Thanks @pao!

[timholy]

For debugging problems in Julia itself, I keep this run_bisect.sh script around:

#! /bin/bash
# Instructions
# Create a .jl file that looks like this:
#        function test()
#           do some stuff, perhaps return a value
#        end
#        @assert test() == 5   # 5 is the correct answer if all is working
#        exit()
# Then provide the name of that function after the "julia" call below
make clean  # or cleanall if you need it
make
julia /tmp/test.jl
exit $?

Then you can do automatic bisection (see the last couple of lines here: http://git-scm.com/book/ch6-5.html). Have a nice meal while you wait.

[kmsquire]

That's also quite useful tim--thanks!

[ViralBShah]

@timholy Your run_bisect.sh script would be good to have in contrib.

[timholy]

See commit 25c1ee2

[Keno]

@kmsquire Did you ever submit this upstream?

[kmsquire]

Not yet, sorry. I'm going to have very spotty internet access until next
week, so not sure I'll get to it until then, but I'll leave it on my todo
list.

On Sat, Jan 5, 2013 at 12:10 AM, Keno Fischer notifications@git.luolix.topwrote:

@kmsquire https://github.com/kmsquire Did you ever submit this upstream?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1689#issuecomment-11910157.

[kmsquire]

Finally submitted upstream: joyent/libuv#685

[kmsquire]

See JuliaLang/libuv#3 (comment)

[nolta]

This has been fixed upstream, can we close this?

[kmsquire]

It's not fixed for julia yet, but there's an issue here: JuliaLang/libuv#5. I personally only use a 32-bit Centos machine when I'm testing portability of a patch. So it's not urgent to me that it's fixed, but I hope it happens before I need it again.

[ViralBShah]

@vtjnash @loladiro Does our libuv now include this upstream patch for CentOS 5? Could one of you cherry-pick the relevant commit so that we can close this?