Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make conversion to integers round #170

Closed
StefanKarpinski opened this issue Aug 11, 2011 · 5 comments
Closed

make conversion to integers round #170

StefanKarpinski opened this issue Aug 11, 2011 · 5 comments
Assignees

Comments

@StefanKarpinski
Copy link
Member

This is easy, per se, but making sure everything that depends on the behavior of conversion to integers doesn't break is harder.

@ghost ghost assigned StefanKarpinski Aug 11, 2011
@JeffBezanson
Copy link
Member

I have nightmares that we will not be able to get this inlined.

@StefanKarpinski
Copy link
Member Author

Do you want to not do it instead?

@JeffBezanson
Copy link
Member

It might be possible. If I can get llvm to inline it we can do it.

@JeffBezanson
Copy link
Member

OK, I can make an intrinsic that efficiently computes itrunc(x+copysign(0.5, x)). Is that an acceptable way to compute this?

@StefanKarpinski
Copy link
Member Author

Looks good to me. Seems to behave identically to x->int(round(x)). The following test code passes:

ir1(x) = int(round(x))
ir2(x) = int(x + copysign(0.5, x))

for x = {-0.5,
         -0.49999999999999999,
         -0.4999999999999999,
          0.0,
          0.4999999999999999,
          0.49999999999999999,
          0.5,
         -Inf,
          Inf,
          NaN,
         -NaN}
    @assert isequal(ir1(x),ir2(x))
end

JeffBezanson added a commit that referenced this issue Aug 12, 2011
adding itrunc for explicit truncating conversion to integer
preparation for fixing issue #170
StefanKarpinski pushed a commit that referenced this issue Feb 8, 2018
ViralBShah pushed a commit that referenced this issue Dec 16, 2024
Stdlib: Statistics
URL: https://github.com/JuliaStats/Statistics.jl.git
Stdlib branch: master
Julia branch: master
Old commit: 68869af
New commit: d49c2bf
Julia version: 1.12.0-DEV
Statistics version: 1.11.2(Does not match)
Bump invoked by: @DilumAluthge
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaStats/Statistics.jl@68869af...d49c2bf

```
$ git log --oneline 68869af..d49c2bf
d49c2bf Merge pull request #178 from JuliaStats/dw/ci
d10d6a3 Update Project.toml
1b67c17 Merge pull request #168 from JuliaStats/andreasnoack-patch-2
c3721ed Add a coverage badge
8086523 Test earliest supported Julia version and prereleases
12a1976 Update codecov in ci.yml
2caf0eb Merge pull request #177 from JuliaStats/ViralBShah-patch-1
33e6e8b Update ci.yml to use julia-actions/cache
a399c19 Merge pull request #176 from JuliaStats/dependabot/github_actions/julia-actions/setup-julia-2
6b8d58a Merge branch 'master' into dependabot/github_actions/julia-actions/setup-julia-2
c2fb201 Merge pull request #175 from JuliaStats/dependabot/github_actions/actions/cache-4
8f808e4 Merge pull request #174 from JuliaStats/dependabot/github_actions/codecov/codecov-action-4
7f82133 Merge pull request #173 from JuliaStats/dependabot/github_actions/actions/checkout-4
046fb6f Update ci.yml
c0fc336 Bump julia-actions/setup-julia from 1 to 2
a95a57a Bump actions/cache from 1 to 4
b675501 Bump codecov/codecov-action from 1 to 4
0088c49 Bump actions/checkout from 2 to 4
ad95c08 Create dependabot.yml
40275e2 Merge pull request #167 from JuliaStats/andreasnoack-patch-1
fa5592a Merge pull request #170 from mbauman/patch-1
cf57562 Add more tests of mean and median of ranges
128dc11 Merge pull request #169 from stevengj/patch-1
48d7a02 docfix: abs2, not ^2
2ac5bec correct std docs: sqrt is elementwise
39f6332 Merge pull request #96 from josemanuel22/mean_may_return_incorrect_results
db3682b Merge branch 'master' into mean_may_return_incorrect_results
9e96507 Update src/Statistics.jl
58e5986 Test prereleases
6e76739 Implement one-argument cov2cor!
b8fee00 Stop testing on nightly
9addbb8 Merge pull request #162 from caleb-allen/patch-1
6e3d223 Merge pull request #164 from aplavin/patch-1
71ebe28 Merge pull request #166 from JuliaStats/dw/cov_cor_optimization
517afa6 add tests
aa0f549 Optimize `cov` and `cor` with identical arguments
cc11ea9 propagate NaN value in median
cf7040f Use non-mobile Wikipedia urls
547bf4d adding docu to mean! explain target should not alias with the source
296650a adding docu to mean! explain target should not alias with the source
```

Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants