Warning for simple Dict on 0.5-rc3

[rened]

I get the following warning for an (I believe?) innocent Dict:

  | | |_| | | | (_| |  |  Version 0.5.0-rc3+0 (2016-08-22 23:43 UTC)
 _/ |\__'_|_|_|\__'_|  |
|__/                   |  x86_64-apple-darwin15.6.0

julia> Dict(1 => rand(2,3), 'c' => "asdf")
WARNING: x::Char == y::Integer is deprecated, use UInt32(x) == y instead.
 in depwarn(::String, ::Symbol) at ./deprecated.jl:64
 in ==(::Char, ::Int64) at ./deprecated.jl:50
 in ht_keyindex2(::Dict{Any,Any}, ::Char) at ./dict.jl:580
 in setindex!(::Dict{Any,Any}, ::String, ::Char) at ./dict.jl:635
 in Dict{Any,Any}(::Tuple{Pair{Int64,Array{Float64,2}},Pair{Char,String}}) at ./dict.jl:349
 in Dict{K,V}(::Pair{Int64,Array{Float64,2}}, ::Pair{Char,String}) at ./dict.jl:380
 in eval(::Module, ::Any) at ./boot.jl:234
 in eval(::Module, ::Any) at /Users/rene/local/julia5/usr/lib/julia/sys.dylib:?
 in eval_user_input(::Any, ::Base.REPL.REPLBackend) at ./REPL.jl:64
 in macro expansion at ./REPL.jl:95 [inlined]
 in (::Base.REPL.##3#4{Base.REPL.REPLBackend})() at ./event.jl:68
while loading no file, in expression starting on line 0
Dict{Any,Any} with 2 entries:
  'c' => "asdf"
  1   => [0.874806 0.180844 0.638005; 0.56545 0.0607152 0.509738]

[KristofferC]

FWIW, I think this depwarn is very annoying and it makes you have to guard code sometimes with !isa(T, Char) && T == 3 if you don't know what T will be.

[martinholters]

This looks like #265 hitting, though, as ht_keyindex2 only calls === and isequal. But it's probably using the definition isequal(x, y) = x == y from operators.jl instead of isequal(x::Char, y::Integer) = false from deprecated.jl. Should we move the latter into operators.jl?

[martinholters]

Confirmed: moving the specialized isequal definitions into operators.jl fixes the issue.