Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Minor) Rephrase 'nonzero entries' in display of SparseMatrix #19119

Closed
colinfang opened this issue Oct 26, 2016 · 3 comments
Closed

(Minor) Rephrase 'nonzero entries' in display of SparseMatrix #19119

colinfang opened this issue Oct 26, 2016 · 3 comments
Labels
docs This change adds or pertains to documentation help wanted Indicates that a maintainer wants help on an issue or pull request sparse Sparse arrays

Comments

@colinfang
Copy link
Contributor

colinfang commented Oct 26, 2016 •
edited
Loading

I would like to suggest we replace nonzero with stored so that it brings less confusion.

Also, there are a lot of places in docs and in code we use the phrase 'structural nonzero values'. IMHO, I find it less readable than a simple 'stored values'.

x = speye(4)
x[1, 1] = 0
display(x)

4×4 sparse matrix with 4 Float64 nonzero entries:
    [1, 1]  =  0.0
    [2, 2]  =  1.0
    [3, 3]  =  1.0
    [4, 4]  =  1.0
@jiahao jiahao added docs This change adds or pertains to documentation help wanted Indicates that a maintainer wants help on an issue or pull request sparse Sparse arrays labels Nov 1, 2016
@akaysh
Copy link
Contributor

akaysh commented Dec 1, 2016

Hi, I am a beginner and want to start contributing to Julia. If this is doable by a beginner, can I take up this issue?
And can anyone guide me on how to approach the problem and what needs to be done?
Thanks

@StefanKarpinski
Copy link
Sponsor Member

Go for it. This should be pretty straightforward.

KristofferC pushed a commit that referenced this issue Jan 3, 2017
@akaysh @KristofferC
Rephrased nonzero to stored for sparse matrix display #19119 (#19483)
2965a33 
* made changes after review 1

* retaining removed tabs in doc strings for tests to pass

* retained nonzero entries for map
@fredrikekre
Copy link
Member

Fixed by #19483 and improved by #20488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs This change adds or pertains to documentation help wanted Indicates that a maintainer wants help on an issue or pull request sparse Sparse arrays
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jiahao @StefanKarpinski @KristofferC @colinfang @akaysh @fredrikekre