Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate nonsensical commutative Dates subtraction methods #20205

Closed
tkelman opened this issue Jan 24, 2017 · 1 comment
Closed

Deprecate nonsensical commutative Dates subtraction methods #20205

tkelman opened this issue Jan 24, 2017 · 1 comment
Assignees
@quinnj
Labels
dates Dates, times, and the Dates stdlib module deprecation This change introduces or involves a deprecation

Comments

@tkelman
Copy link
Contributor

tkelman commented Jan 24, 2017

See https://github.com/JuliaLang/julia/pull/12274/files#r96932819 - for the ones that just got added we should delete them immediately, for the ones that have been around longer we can go through a deprecation cycle. Can anyone explain if these are useful or correct in any context?

julia> Dates.Day(1) - Date(2016, 1, 1)
2015-12-31

julia> Dates.Hour(24) - Dates.Time(Dates.Hour(1))
01:00:00
@tkelman tkelman added dates Dates, times, and the Dates stdlib module deprecation This change introduces or involves a deprecation labels Jan 24, 2017
@tkelman tkelman mentioned this issue Jan 24, 2017
Merged
3 tasks
quinnj added a commit that referenced this issue Jan 25, 2017
@quinnj
Remove commutative subtraction methods. Fixes #20205
4118f6a
@tkelman
Copy link
Contributor Author

tkelman commented Jan 25, 2017

x-ref the related #12084, #12094, #12115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quinnj quinnj

Labels
dates Dates, times, and the Dates stdlib module deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@omus @quinnj @tkelman