Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arg-specificity assertion #22338

Closed
vtjnash opened this issue Jun 12, 2017 · 0 comments
Closed

arg-specificity assertion #22338

vtjnash opened this issue Jun 12, 2017 · 0 comments
Assignees
@JeffBezanson
Labels
bug Indicates an unexpected problem or unintended behavior types and dispatch Types, subtyping and method dispatch

Comments

@vtjnash
Copy link
Member

vtjnash commented Jun 12, 2017 

julia> A = Tuple{Ref, Tuple{T}} where T
julia> B = Tuple{Ref{T}, Tuple{Vararg{T}}} where T
args_morespecific(A, B) will assert

This affects StaticArrays (https://github.com/JuliaArrays/StaticArrays.jl/blob/0cbb2812ce9230773dc7555171178660d1fbda51/src/Scalar.jl#L9)
@vtjnash vtjnash added backport pending 0.6 bug Indicates an unexpected problem or unintended behavior types and dispatch Types, subtyping and method dispatch labels Jun 12, 2017
@JeffBezanson JeffBezanson mentioned this issue Jun 12, 2017
Closed
JeffBezanson added a commit that referenced this issue Jun 12, 2017
@JeffBezanson
fix #22338 and #22339, specificity problems
bd2dcf1
JeffBezanson added a commit that referenced this issue Jun 13, 2017
@JeffBezanson
Merge pull request #22343 from JuliaLang/jb/fix22338
01c6816 
fix #22338 and #22339, specificity problems
JeffBezanson added a commit that referenced this issue Jun 15, 2017
@JeffBezanson
fix #22338 and #22339, specificity problems
ca8dcba 
(cherry picked from commit bd2dcf1)

Conflicts:
	test/specificity.jl
JeffBezanson added a commit that referenced this issue Jun 15, 2017
@JeffBezanson
fix #22338 and #22339, specificity problems
25d8c3a 
Backported from PR #22343

(cherry picked from commit bd2dcf1)

Conflicts:
	test/specificity.jl
tkelman added a commit that referenced this issue Jun 18, 2017
@tkelman
Revert "fix #22338 and #22339, specificity problems"
f45247c 
This reverts commit 25d8c3a.
This caused test failures in CategoricalArrays and ReverseDiff
quinnj pushed a commit that referenced this issue Jun 20, 2017
@JeffBezanson @quinnj
fix #22338 and #22339, specificity problems
ec3df68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeffBezanson JeffBezanson

Labels
bug Indicates an unexpected problem or unintended behavior types and dispatch Types, subtyping and method dispatch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vtjnash @JeffBezanson