-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make find
's default predicate be identity
#23120
Comments
+1 If we do that, then the Search & Find Julep should be updated to say "true values" rather than "non zeros" in a few places. |
JeffBezanson
added a commit
that referenced
this issue
Sep 21, 2017
JeffBezanson
added a commit
that referenced
this issue
Sep 22, 2017
JeffBezanson
added a commit
that referenced
this issue
Sep 22, 2017
JeffBezanson
added a commit
that referenced
this issue
Sep 22, 2017
JeffBezanson
added a commit
that referenced
this issue
Sep 22, 2017
JeffBezanson
added a commit
that referenced
this issue
Sep 26, 2017
JeffBezanson
added a commit
that referenced
this issue
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed in #23005, the zeroness predicate is not uniquely defined. It seems odd to pick one for
find
. However, one really useful property of this is that it returns thetrue
indices for boolean arrays, so you can do things likefind(x .== 1)
, which we should preserve. I thus propose to make the default predicate beidentity
to retain the useful behavior for boolean arrays, but force the user to choose their predicate for numeric arrays.The text was updated successfully, but these errors were encountered: