Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing BoundsError on BitArray #2495

Closed
diegozea opened this issue Mar 7, 2013 · 2 comments
Closed

Missing BoundsError on BitArray #2495

diegozea opened this issue Mar 7, 2013 · 2 comments
Labels
bug Indicates an unexpected problem or unintended behavior
Milestone
0.7

Comments

@diegozea
Copy link
Contributor

diegozea commented Mar 7, 2013 

julia> example = mod([ 1  3 2 4 ;  6 5 7 8 ],2) .== 1
2x4 BitArray:
  true  true  false  false
 false  true   true  false

julia> example[:,5] # Doesn't exist, missing BoundsError
2-element BitArray:
 false
 false

julia> example[:,50]
ERROR: BoundsError()
 in glue_src_bitchunks at bitarray.jl:51
@JeffBezanson
Copy link
Sponsor Member

Good catch!

JeffBezanson added a commit that referenced this issue Mar 8, 2013
@JeffBezanson
add a missing bitarray bounds check. for #2495
4629261 
some scalar cases are still missing bounds checks, and we have enough
bitarray performance trouble as it is. we will need the ability to force
inlining before it becomes practical to fix.
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 16, 2013

Since #2360 has apparently improved the performance, is it reasonable to look into this again?

@JeffBezanson JeffBezanson mentioned this issue Oct 28, 2013
Merged
carlobaldassi added a commit that referenced this issue Oct 28, 2013
@carlobaldassi
bitarray: full multidimensional bounds checks
04c4707 
Fix #2495
carlobaldassi added a commit that referenced this issue Nov 18, 2013
@carlobaldassi @jiahao
bitarray: full multidimensional bounds checks
aabb42a 
Fix #2495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
3 participants
@vtjnash @JeffBezanson @diegozea