deprecate ipermute! in favor of invpermute! #25168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
approved these changes
Dec 18, 2017
Sacha0
reviewed
Dec 18, 2017
NEWS.md
Outdated
| @@ -816,6 +816,8 @@ Deprecated or removed | |||
| and `unsafe_get`/`get` can be dropped or replaced with `coalesce`. | |||
| `NullException` has been removed. | |||
|
|
|||
| * `ipermute!` has been deprecated in favor of `invpermute` ([#25168]). | |||
rfourquet
force-pushed
the
rf/ipermute
branch
from
81ef172
to
45acdb7
Compare
ararslan
reviewed
Dec 18, 2017
base/deprecated.jl
Outdated
| @@ -363,6 +363,9 @@ end | |||
|
|
|||
| @deprecate ipermutedims(A::AbstractArray,p) permutedims(A, invperm(p)) | |||
|
|
|||
| # PR #25168 | |||
| @deprecate ipermute!(a, p::AbstractVector) invpermute!(a, p::AbstractVector) | |||
There was a problem hiding this comment.
I don't think the deprecation target should have the type annotation, since @deprecate turns it into function definition which means that on the RHS it's a type assertion.
rfourquet
force-pushed
the
rf/ipermute
branch
from
45acdb7
to
b1cfcab
Compare
ararslan
approved these changes
Dec 19, 2017
rfourquet
force-pushed
the
rf/ipermute
branch
from
b1cfcab
to
48b9629
Compare
|
The CI errors are unrelated (libgit2 and |
|
I can't see this deprecation—i.e. typing |
|
Looks like the deprecations where added to the wrong section and got removed in e858f55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to be consistent with
invperm. And it's more explicit.