Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug or incorrect documentation for retry method? #25351

Closed
tanmaykm opened this issue Jan 2, 2018 · 3 comments
Closed

bug or incorrect documentation for retry method? #25351

tanmaykm opened this issue Jan 2, 2018 · 3 comments

Comments

@tanmaykm
Copy link
Member

tanmaykm commented Jan 2, 2018

The check parameter for retry is documented to return a boolean here

But code seems to expect a tuple of state and boolean here

Appears to have been introduced in #19331
@tanmaykm
Copy link
Member Author

tanmaykm commented Jan 2, 2018

Looks to be a code typo. PR in a bit.

tanmaykm added a commit to tanmaykm/julia that referenced this issue Jan 2, 2018
@tanmaykm
fix typo in retry check
7eb201f 
fixes JuliaLang#25351

The retry check method is expected to return a boolean value.
There does not seem to be a reason to expect the state to be returned.
That seems to be a typo, which this corrects.
@tanmaykm tanmaykm mentioned this issue Jan 2, 2018
Closed
@tanmaykm
Copy link
Member Author

tanmaykm commented Jan 2, 2018

Hmm... Seems to be the other way round. Because the current tests return tuple.

tanmaykm added a commit to tanmaykm/julia that referenced this issue Jan 2, 2018
@tanmaykm
correct doc string for retry
f131c38 
fixes JuliaLang#25351

The retry check function is expected to return a tuple of state and boolean
tanmaykm added a commit to tanmaykm/julia that referenced this issue Jan 2, 2018
@tanmaykm
correct doc string for retry [ci skip]
dbafd0b 
fixes JuliaLang#25351

The retry check function is expected to return a tuple of state and boolean

[ci skip]
tanmaykm added a commit to tanmaykm/julia that referenced this issue Mar 19, 2019
@tanmaykm
correct doc string for retry [ci skip]
d2960e0 
fixes JuliaLang#25351

The retry check function is expected to return a tuple of state and boolean

[ci skip]
@tanmaykm
Copy link
Member Author

tanmaykm commented May 1, 2020

Closing. Fixed in #26138

@tanmaykm tanmaykm closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix typo in retry check doc string tanmaykm/julia
1 participant
@tanmaykm