Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add probe-stack support to Julia #25523

Closed
vtjnash opened this issue Jan 12, 2018 · 4 comments
Closed

add probe-stack support to Julia #25523

vtjnash opened this issue Jan 12, 2018 · 4 comments
Labels
compiler:codegen Generation of LLVM IR and native code help wanted Indicates that a maintainer wants help on an issue or pull request

Comments

@vtjnash
Copy link
Member

vtjnash commented Jan 12, 2018

Looks like support for the "probe-stack" attribute finally landed in LLVM (https://reviews.llvm.org/D34386) thanks to the Rust folks (rust-lang/rust#16012). We should start setting this function attribute in Julia too.

@vtjnash vtjnash added help wanted Indicates that a maintainer wants help on an issue or pull request compiler:codegen Generation of LLVM IR and native code labels Jan 12, 2018
@fisiognomico
Copy link
Contributor

It should not be so hard, as now Julia uses LLVM 6.0.0 it is just needed to add a pass on codegen.
The problem is that looking at Rust stack probes are incompatible with address sanitizer, so maybe it would be wiser to wait that #27167 gets merged, as maybe we can get similar problems in the future for MSAN or TSAN.

@vchuravy
Copy link
Member

so maybe it would be wiser to wait that #27167 gets merged, as maybe we can get similar problems in the future for MSAN or TSAN

Best not to block work on the TSAN support, we only need a way to disable probe-stack when sanitizers are used and I can rebase that PR later.

@fisiognomico
Copy link
Contributor

Yeah we can think about that later. Also it seems that the issue is present only with Address Sanitizer, the others are unaffected. I will test it later!

@eulerkochy
Copy link
Contributor

@vtjnash I'm interested to work on this issue. Can you please give me a headstart about the problems and different reading materials?

vtjnash added a commit that referenced this issue Mar 16, 2021
Supported platforms are currently X86, PowerPC, and SystemZ.

Fixes #25523
Fixes #36170
Closes #28577
Closes #30892
vtjnash added a commit that referenced this issue Mar 18, 2021
Supported platforms are currently X86, PowerPC, and SystemZ.

Fixes #25523
Fixes #36170
Closes #28577
Closes #30892
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this issue May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this issue May 9, 2021
johanmon pushed a commit to johanmon/julia that referenced this issue Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code help wanted Indicates that a maintainer wants help on an issue or pull request
Projects
None yet
Development

No branches or pull requests

4 participants