Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdDict broken badly? #26833

Closed
vtjnash opened this issue Apr 17, 2018 · 1 comment
Closed

IdDict broken badly? #26833

vtjnash opened this issue Apr 17, 2018 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior priority This should be addressed urgently

Comments

@vtjnash
Copy link
Member

vtjnash commented Apr 17, 2018

Adding (setindex) and removing (pop) items repeatedly from IdDict appears to result in some of the operations getting forgotten. This is very, very bad. (tested on v0.6 and master)
@vtjnash vtjnash added bug Indicates an unexpected problem or unintended behavior priority This should be addressed urgently backport pending 0.6 labels Apr 17, 2018
@StefanKarpinski
Copy link
Member

MWE?

vtjnash added a commit that referenced this issue Apr 17, 2018
@vtjnash
IdDict: support deletion, and support nothing used as a key
8273676 
previously, if we deleted one key or added `nothing` as a key,
we might lose some of the other entries too (until rehash)

fix #26833
vtjnash added a commit that referenced this issue Apr 19, 2018
@vtjnash
IdDict: support deletion, and support nothing used as a key
d3d58b4 
previously, if we deleted one key or added `nothing` as a key,
we might lose some of the other entries too (until rehash)

fix #26833
vtjnash added a commit that referenced this issue Apr 27, 2018
@vtjnash
IdDict: support deletion, and support nothing used as a key
6d60f78 
previously, if we deleted one key or added `nothing` as a key,
we might lose some of the other entries too (until rehash)

fix #26833

(cherry-pick PR #26839, 5e57c21)
ararslan pushed a commit that referenced this issue Apr 27, 2018
@vtjnash @ararslan
IdDict: support deletion, and support nothing used as a key
1f810f1 
previously, if we deleted one key or added `nothing` as a key,
we might lose some of the other entries too (until rehash)

fix #26833

(cherry-pick PR #26839, 5e57c21)

(cherry picked from commit 6d60f78)
ararslan pushed a commit that referenced this issue May 8, 2018
@vtjnash @ararslan
IdDict: support deletion, and support nothing used as a key
fe59a2b 
previously, if we deleted one key or added `nothing` as a key,
we might lose some of the other entries too (until rehash)

fix #26833

(cherry-pick PR #26839, 5e57c21)

(cherry picked from commit 6d60f78)
@JeffBezanson JeffBezanson mentioned this issue Jul 10, 2018
Closed
vtjnash added a commit that referenced this issue Aug 25, 2021
@vtjnash
fix ptrhash_remove
26fad6b 
Same bug as 5e57c21 (#26833), same fix.
vtjnash added a commit that referenced this issue Aug 25, 2021
@vtjnash
fix ptrhash_remove
23b57aa 
Same bug as 5e57c21 (#26833), same fix.
vtjnash added a commit that referenced this issue Aug 25, 2021
@vtjnash
fix ptrhash_remove
1050cee 
Same bug as 5e57c21 (#26833), same fix.
@vtjnash vtjnash mentioned this issue Aug 25, 2021
Merged
vtjnash added a commit that referenced this issue Aug 26, 2021
@vtjnash
fix ptrhash_remove (#42009)
82c4a27 
Same bug as 5e57c21 (#26833), same fix.
KristofferC pushed a commit that referenced this issue Aug 27, 2021
@vtjnash @KristofferC
fix ptrhash_remove (#42009)
4cddbea 
Same bug as 5e57c21 (#26833), same fix.

(cherry picked from commit 82c4a27)
KristofferC pushed a commit that referenced this issue Sep 3, 2021
@vtjnash @KristofferC
fix ptrhash_remove (#42009)
c344ba5 
Same bug as 5e57c21 (#26833), same fix.

(cherry picked from commit 82c4a27)
KristofferC pushed a commit that referenced this issue Sep 6, 2021
@vtjnash @KristofferC
fix ptrhash_remove (#42009)
51a0b80 
Same bug as 5e57c21 (#26833), same fix.

(cherry picked from commit 82c4a27)
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Feb 22, 2022
@vtjnash @LilithHafner
fix ptrhash_remove (JuliaLang#42009)
247c81d 
Same bug as 5e57c21 (JuliaLang#26833), same fix.
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Mar 8, 2022
@vtjnash @LilithHafner
fix ptrhash_remove (JuliaLang#42009)
5ccf6e6 
Same bug as 5e57c21 (JuliaLang#26833), same fix.
staticfloat pushed a commit that referenced this issue Dec 23, 2022
@vtjnash @staticfloat
fix ptrhash_remove (#42009)
1583306 
Same bug as 5e57c21 (#26833), same fix.

(cherry picked from commit 82c4a27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior priority This should be addressed urgently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefanKarpinski @vtjnash