REPL shell mode IOError when changing directories

[CiaranOMara]

Julia's REPL shell mode produces an error when executing a basic cd command when the default shell is fish and has the bobthefish theme active. The theme displays and formats some useful information.

The error does not occur when the default shell is /bin/bash.

               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.0.0 (2018-08-08)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> versioninfo()
Julia Version 1.0.0
Commit 5d4eaca0c9 (2018-08-08 20:58 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin14.5.0)
  CPU: Intel(R) Core(TM) i7-4960HQ CPU @ 2.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.0 (ORCJIT, haswell)

shell> cd
/Users/me

shell> cd Do
Documents/ Downloads/
shell> cd Documents/
ERROR: IOError: chdir 7878: no such file or directory (ENOENT)
Stacktrace:
 [1] uv_error at ./libuv.jl:85 [inlined]
 [2] cd(::String) at ./file.jl:76
 [3] repl_cmd(::Cmd, ::REPL.Terminals.TTYTerminal) at ./client.jl:61
 [4] top-level scope at none:0

julia> pwd()
"/Users/me"

shell> pwd
/Users/me

julia> cd("Documents")

julia> pwd()
"/Users/me/Documents"

shell> pwd
/Users/me/Documents

julia> 

[favba]

I experience the same error using fish as default shell. I don't have this bobthefish theme installed, so it seems to be some problem with fish shell alone.

[favba]

This seems to be the culprit (I have no idea what is the need for that line...):

julia/base/client.jl

Line 59 in 883c8a3

dir = read(`$shell -c "printf %s $(shell_escape_posixly(dir))"`, String)

on fish:

~> printf %s "/home"
74883

bash:

bash-3.2$ printf %s "/home"
/home

Now, if we change the command a bit, it works on both shells (and this is the way I see it done more often)

on fish:

~> printf "%s" "/home"
/home

bash:

bash-3.2$ printf "%s" "/home"
/home

I opened an issue for fish to see if this is a bug from fish.

[favba]

This is fixed on fish master and will be released only for fish 3.0, which I don't know when will be released. I made a PR here to make it work...

[CiaranOMara]

Thank you @favba.