Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In iterators.jl:1092 and 1095 Stateful{T,VS} is reversed to {VS,T} #30643

Closed
denizyuret opened this issue Jan 8, 2019 · 1 comment
Closed

In iterators.jl:1092 and 1095 Stateful{T,VS} is reversed to {VS,T} #30643

denizyuret opened this issue Jan 8, 2019 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@denizyuret
Copy link
Contributor

julia/base/iterators.jl

Line 1092 in 34f7a4a

IteratorSize(::Type{Stateful{VS,T}} where VS) where {T} =

e.g. Stateful(cycle(itr)) claims it has length.
@JeffBezanson JeffBezanson added the bug Indicates an unexpected problem or unintended behavior label Jan 8, 2019
@JeffBezanson
Copy link
Member

Wow, thank you. Good catch. Could you prepare a PR?

denizyuret added a commit to denizyuret/julia that referenced this issue Jan 8, 2019
@denizyuret
fixing JuliaLang#30643
6869ae1 
Not sure what the previous definition of IteratorSize was trying to do, but it was wrong for IsInfinite. Not sure what the correct answer is for HasShape.
denizyuret added a commit to denizyuret/julia that referenced this issue Jan 8, 2019
@denizyuret
Added tests for Stateful fix JuliaLang#30643
c0eb6c9
@KristofferC KristofferC mentioned this issue Jan 11, 2019
Closed
53 tasks
KristofferC pushed a commit that referenced this issue Jan 11, 2019
@denizyuret @KristofferC
fix #30643, correctly propagate iterator traits through Stateful (#30644
543cf24 
)

(cherry picked from commit 21dfef3)
@KristofferC KristofferC mentioned this issue Feb 4, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this issue Feb 4, 2019
@denizyuret @KristofferC
fix #30643, correctly propagate iterator traits through Stateful (#30644
e274a21 
)
KristofferC pushed a commit that referenced this issue Feb 4, 2019
@denizyuret @KristofferC
fix #30643, correctly propagate iterator traits through Stateful (#30644
a6392c5 
)
KristofferC pushed a commit that referenced this issue Feb 11, 2019
@denizyuret @KristofferC
fix #30643, correctly propagate iterator traits through Stateful (#30644
4b6e6b5 
)
KristofferC pushed a commit that referenced this issue Feb 11, 2019
@denizyuret @KristofferC
fix #30643, correctly propagate iterator traits through Stateful (#30644
42fe9fc 
)
KristofferC pushed a commit that referenced this issue Feb 11, 2019
@denizyuret @KristofferC
fix #30643, correctly propagate iterator traits through Stateful (#30644
a22e161 
)

(cherry picked from commit 21dfef3)
@KristofferC KristofferC mentioned this issue Feb 11, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this issue Feb 11, 2019
@denizyuret @KristofferC
fix #30643, correctly propagate iterator traits through Stateful (#30644
a1eafdf 
)
KristofferC pushed a commit that referenced this issue Apr 20, 2019
@denizyuret @KristofferC
fix #30643, correctly propagate iterator traits through Stateful (#30644
54a71f6 
)
KristofferC pushed a commit that referenced this issue Feb 20, 2020
@denizyuret @KristofferC
fix #30643, correctly propagate iterator traits through Stateful (#30644
0c40ad2 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeffBezanson @denizyuret