Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export istaskfailed #32300

Merged
merged 3 commits into from
Jul 5, 2019
Merged

Export istaskfailed #32300

merged 3 commits into from
Jul 5, 2019

Conversation

iamed2
Copy link
Contributor

@iamed2 iamed2 commented Jun 11, 2019

This can be pretty useful for testing and there doesn't seem to be much difference between it and its istask friends.

@jmkuhn
Copy link
Contributor

jmkuhn commented Jun 12, 2019

If this is exported, it will need a docstring.

@fredrikekre fredrikekre added the needs news A NEWS entry is required for this change label Jun 12, 2019
@iamed2 iamed2 force-pushed the ed/export-istaskfailed branch from 18c2160 to fd9e4c6 Compare July 5, 2019 16:56
@iamed2
Copy link
Contributor Author

iamed2 commented Jul 5, 2019

Now has news

@omus omus removed the needs news A NEWS entry is required for this change label Jul 5, 2019
NEWS.md Outdated Show resolved Hide resolved
@iamed2 iamed2 force-pushed the ed/export-istaskfailed branch from fd9e4c6 to e596dc0 Compare July 5, 2019 17:13
@omus omus merged commit e6379da into JuliaLang:master Jul 5, 2019
@omus omus deleted the ed/export-istaskfailed branch July 5, 2019 19:41
@fredrikekre fredrikekre added the needs compat annotation Add !!! compat "Julia x.y" to the docstring label Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs compat annotation Add !!! compat "Julia x.y" to the docstring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants