Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Quarter period #35519

Closed
wants to merge 7 commits into from
Closed

add Quarter period #35519

wants to merge 7 commits into from

Conversation

matthieugomez
Copy link
Contributor

@matthieugomez matthieugomez commented Apr 18, 2020 •
edited
Loading

Similarly to the fact that a Week corresponds to seven days, a Quarter corresponds to three months. @quinnj

#35517

@matthieugomez
Copy link
Contributor Author

matthieugomez commented Apr 20, 2020 •
edited
Loading

I have not touched the quarterofyear function but maybe it should be renamed to quarter.

@JeffBezanson JeffBezanson added the dates Dates, times, and the Dates stdlib module label Apr 20, 2020
quinnj
quinnj approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; no support for parsing/formatting, but it's not a very common use-case anyway.

@matthieugomez
Copy link
Contributor Author

matthieugomez commented Apr 24, 2020 •
edited
Loading

One last point. For now, I don't export quarter: this is a bit weird — accessor functions are exported for all other Periods . The reason I don't do this is that there is already a function, quarterofyear, that does exactly the same thing.

So, should I still export quarter? If yes, should I deprecate quarterfoyear?

@quinnj
Copy link
Member

quinnj commented Jun 12, 2020

Looks like this needs a rebase and can be merged

@matthieugomez matthieugomez mentioned this pull request Jun 19, 2020
Merged
@quinnj quinnj closed this Jul 4, 2020
@PaulSoderlind PaulSoderlind mentioned this pull request Nov 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
dates Dates, times, and the Dates stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthieugomez @quinnj @JeffBezanson