Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make register_error_hint experimental #35671

Closed
StefanKarpinski opened this issue Apr 30, 2020 · 1 comment · Fixed by #35679
Closed

make register_error_hint experimental #35671

StefanKarpinski opened this issue Apr 30, 2020 · 1 comment · Fixed by #35679
Milestone

Comments

@StefanKarpinski
Copy link
Sponsor Member

In discussing #35094 on this last triage call before the 1.5 feature freeze, it was felt that this should be an experimental feature for a while. The concern is that the current form may have bad consequences for compilation time and that it may need changing if that turns out to be the case. There are two things to be done:

  1. export the new exports from the Experimental submodule instead of directly from Base
  2. document that it is experimental.
@StefanKarpinski StefanKarpinski added this to the 1.5 milestone Apr 30, 2020
@StefanKarpinski StefanKarpinski changed the title make register_error_hint experimental (1.5) make register_error_hint experimental Apr 30, 2020
timholy added a commit that referenced this issue May 1, 2020
@timholy
Copy link
Sponsor Member

timholy commented May 1, 2020

I did not export them at all from Experimental, is that OK? xref #35679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants