Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jl_egal and jl_gc_safepoint are not exported by Julia 1.8.0-beta1 #44373

Closed
Taaitaaiger opened this issue Feb 28, 2022 · 1 comment · Fixed by #44419
Closed

jl_egal and jl_gc_safepoint are not exported by Julia 1.8.0-beta1 #44373

Taaitaaiger opened this issue Feb 28, 2022 · 1 comment · Fixed by #44419
Labels
regression Regression in behavior compared to a previous version
Milestone
1.8

Comments

@Taaitaaiger
Copy link
Contributor

These two functions were exported by earlier versions of Julia but are no longer available in the current beta. I tried adding these functions to jl_exported_funcs.inc, but compilation fails if jl_egal is added to this list.
@vtjnash
Copy link
Member

vtjnash commented Feb 28, 2022

Those are macros, so we need to update the tricks somewhat that we use to export them. Used to be just () like this:

julia/src/jlapi.c

Line 462 in 8bdb045

JL_DLLEXPORT void (jl_gc_safepoint)(void)

Now those need an i prefix and to get undef before being defined:

julia/src/julia_internal.h

Lines 426 to 428 in 8bdb045

#undef jl_svec
#define jl_svec(n, ...) \
(ijl_svec)(__extension__({ \

@vtjnash vtjnash added backport 1.8 Change should be backported to release-1.8 regression Regression in behavior compared to a previous version labels Feb 28, 2022
@fredrikekre fredrikekre added this to the 1.8 milestone Feb 28, 2022
vtjnash added a commit that referenced this issue Mar 2, 2022
@vtjnash
add jl_egal and jl_gc_safepoint back to exports list
5e265fe 
Simple oversight when these were turned into macros. I could not find
any others that seemed applicable, so just these two appeared to need
fixing right now.

Fix #44373
@vtjnash vtjnash mentioned this issue Mar 2, 2022
Merged
vtjnash added a commit that referenced this issue Mar 3, 2022
@vtjnash
add jl_egal and jl_gc_safepoint back to exports list (#44419)
8eb872c 
Simple oversight when these were turned into macros. I could not find
any others that seemed applicable, so just these two appeared to need
fixing right now.

Fix #44373
KristofferC pushed a commit that referenced this issue Mar 4, 2022
@vtjnash @KristofferC
add jl_egal and jl_gc_safepoint back to exports list (#44419)
b1312f6 
Simple oversight when these were turned into macros. I could not find
any others that seemed applicable, so just these two appeared to need
fixing right now.

Fix #44373

(cherry picked from commit 8eb872c)
KristofferC pushed a commit that referenced this issue Mar 7, 2022
@vtjnash @KristofferC
add jl_egal and jl_gc_safepoint back to exports list (#44419)
1cd27ca 
Simple oversight when these were turned into macros. I could not find
any others that seemed applicable, so just these two appeared to need
fixing right now.

Fix #44373

(cherry picked from commit 8eb872c)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

add jl_egal and jl_gc_safepoint back to exports list JuliaLang/julia
4 participants
@vtjnash @KristofferC @fredrikekre @Taaitaaiger