Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base.libllvm_path and jl_get_libllvm don't support non-ASCII characters in path on Windows #45126

Closed
wesjenkins opened this issue Apr 30, 2022 · 0 comments · Fixed by #45127
Closed

Base.libllvm_path and jl_get_libllvm don't support non-ASCII characters in path on Windows #45126

wesjenkins opened this issue Apr 30, 2022 · 0 comments · Fixed by #45127

Comments

@wesjenkins
Copy link
Contributor

On Windows, if there are non-ASCII character in the path to LLVM--for example, if someone's name is non-English--then the function will not return the correct result. The function does not error, it just returns malformed UTF-8. However, this results in packages like LLVM.jl refusing to compile if the returned string is malformed UTF-8.
@wesjenkins wesjenkins mentioned this issue Apr 30, 2022
Merged
@giordano giordano linked a pull request Apr 30, 2022 that will close this issue
Fix Base.libllvm_path and jl_get_libllvm don't support non-ASCII characters in path on Windows (#45126) #45127
Merged
@melonedo melonedo mentioned this issue Feb 11, 2023
Closed
KristofferC pushed a commit that referenced this issue Feb 14, 2023
@wesjenkins
Fix Base.libllvm_path and jl_get_libllvm don't support non-ASCII char…
6976bac 
…acters in path on Windows (#45126) (#45127)

* Fix jl_get_libllvm_impl to support non-ASCII characters

* Fix jl_get_libllvm_impl to support non-ASCII characters, fix whitespace

* Fix jl_get_libllvm_impl to support non-ASCII characters, fix null and buffer
KristofferC pushed a commit that referenced this issue Feb 20, 2023
@wesjenkins
Fix Base.libllvm_path and jl_get_libllvm don't support non-ASCII char…
b3d42d1 
…acters in path on Windows (#45126) (#45127)

* Fix jl_get_libllvm_impl to support non-ASCII characters

* Fix jl_get_libllvm_impl to support non-ASCII characters, fix whitespace

* Fix jl_get_libllvm_impl to support non-ASCII characters, fix null and buffer

(cherry picked from commit 6976bac)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@wesjenkins