Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash screen days-count fails #5218

Closed
ivarne opened this issue Dec 22, 2013 · 1 comment
Closed

Splash screen days-count fails #5218

ivarne opened this issue Dec 22, 2013 · 1 comment

Comments

@ivarne
Copy link
Sponsor Member

ivarne commented Dec 22, 2013

The splash screen get created in base/version.jl, and currently the age calculation is only performed at compile time (when i type make), and not every time you start Julia as it was intended. I think this has something to do with #4898, but there might be related to some REPL work that I did not notice.

It would be nice if someone could give me some hint about how to structure the code to make this work.

Start up time is definitely something that is highly overvalued by people evaluating Julia, so the best option might be to remove the age altogether, but I think it is useful as a warning to those that run nightly/git versions to upgrade often, and always before submitting a bug report.
@StefanKarpinski
Copy link
Sponsor Member

I'm not really super into the age bit. It seems a bit weird for the splash info to change all the time.

ivarne added a commit to ivarne/julia that referenced this issue Jan 2, 2014
@ivarne
Fix JuliaLang#5218, Compile age in banner
df9c439 
After static compillation of base Julia was implemented, the startup
banner showed the age of the newest commit in (origin/)master at the
time of compillation, instead of at startup time. This commit moves the
age calculation into the Base.banner() function, and moves the function
from base/client.jl to base/version.jl in order to have access to the
right variables.
staticfloat added a commit that referenced this issue Jan 2, 2014
@staticfloat
Fix #5218, calculate age of Julia checkout in banner() function
c629eb2 
After static compillation of base Julia was implemented, the startup
banner showed the age of the newest commit in (origin/)master at the
time of compillation, instead of at startup time. This commit moves the
age calculation into the Base.banner() function, and moves the function
from base/client.jl to base/version.jl in order to have access to the
right variables.
staticfloat added a commit that referenced this issue Jan 2, 2014
@staticfloat
Fix #5218, calculate age of Julia checkout in banner() function
fe04a00 
After static compillation of base Julia was implemented, the startup
banner showed the age of the newest commit in (origin/)master at the
time of compillation, instead of at startup time. This commit moves the
age calculation into the Base.banner() function, and moves the function
from base/client.jl to base/version.jl in order to have access to the
right variables. (Thanks @ivarne!)
staticfloat added a commit that referenced this issue Jan 2, 2014
@staticfloat
Merge pull request #5281 from ivarne/splash-fix
e3ea35b 
Fix #5218, Compile age in banner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivarne @StefanKarpinski