-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigInt crashes/hangs with bad String inputs #530
Labels
bug
Indicates an unexpected problem or unintended behavior
Comments
Also seem to hang, sometimes, on just regular construction julia> b = BigInt(5) |
FYI: This is on a "hand-compiled" Mac OS X build. |
Will take a look .. the bigint tests seem to fail for me now :( |
Converting to string seems clearly broken now for me. |
I think I fixed this with: #532 |
This bug can now be closed, since pull request 532 has been merged. |
Thanks @choffstein for finding and fixing this |
KristofferC
pushed a commit
that referenced
this issue
Jul 27, 2018
* Update copypasta line I'm note sure what goes in `???` but just to get the PR rolling. * Fill in the text for manifest mode Based on what I see at https://docs.julialang.org/en/latest/stdlib/Pkg/#Adding-registered-packages-1 this text seems correct. * Editorial fix
KristofferC
pushed a commit
that referenced
this issue
Jul 27, 2018
* Update copypasta line I'm note sure what goes in `???` but just to get the PR rolling. * Fill in the text for manifest mode Based on what I see at https://docs.julialang.org/en/latest/stdlib/Pkg/#Adding-registered-packages-1 this text seems correct. * Editorial fix
KristofferC
pushed a commit
that referenced
this issue
Feb 11, 2019
* Update copypasta line I'm note sure what goes in `???` but just to get the PR rolling. * Fill in the text for manifest mode Based on what I see at https://docs.julialang.org/en/latest/stdlib/Pkg/#Adding-registered-packages-1 this text seems correct. * Editorial fix
Keno
pushed a commit
that referenced
this issue
Oct 9, 2023
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
dkarrasch
pushed a commit
that referenced
this issue
May 8, 2024
Stdlib: SparseArrays URL: https://github.com/JuliaSparse/SparseArrays.jl.git Stdlib branch: main Julia branch: master Old commit: cb602d7 New commit: a09f90b Julia version: 1.12.0-DEV SparseArrays version: 1.12.0 Bump invoked by: @dkarrasch Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaSparse/SparseArrays.jl@cb602d7...a09f90b ``` $ git log --oneline cb602d7..a09f90b a09f90b Adjust matvec and matmatmul! to new internal LinAlg interface (#519) 3b30333 ci: run aqua test as a standalone ci job (#537) df0a154 Add versioned Manifest files to .gitignore (#534) 4606755 Extend `copytrito!` for a sparse source (#533) 33fbc75 SparseMatrixCSC constructor with a Tuple of Integers (#523) 08d6ae1 CI: don't run `threads` tests in Windows GHA CI (attempt 2) (#530) 7408e4b Revert "Don't fail CI if codecov upload fails." (#527) 287e406 Bump julia-actions/setup-julia from 1 to 2 (#524) b5de0da Don't fail CI if codecov upload fails. (#525) 78dde4c cast to Float64 directly instead of using float (#521) a5e95ec CI: Add Apple Silicon (macOS aarch64) to the CI matrix (#505) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
xlxs4
pushed a commit
to xlxs4/julia
that referenced
this issue
May 9, 2024
…aLang#54406) Stdlib: SparseArrays URL: https://github.com/JuliaSparse/SparseArrays.jl.git Stdlib branch: main Julia branch: master Old commit: cb602d7 New commit: a09f90b Julia version: 1.12.0-DEV SparseArrays version: 1.12.0 Bump invoked by: @dkarrasch Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaSparse/SparseArrays.jl@cb602d7...a09f90b ``` $ git log --oneline cb602d7..a09f90b a09f90b Adjust matvec and matmatmul! to new internal LinAlg interface (JuliaLang#519) 3b30333 ci: run aqua test as a standalone ci job (JuliaLang#537) df0a154 Add versioned Manifest files to .gitignore (JuliaLang#534) 4606755 Extend `copytrito!` for a sparse source (JuliaLang#533) 33fbc75 SparseMatrixCSC constructor with a Tuple of Integers (JuliaLang#523) 08d6ae1 CI: don't run `threads` tests in Windows GHA CI (attempt 2) (JuliaLang#530) 7408e4b Revert "Don't fail CI if codecov upload fails." (JuliaLang#527) 287e406 Bump julia-actions/setup-julia from 1 to 2 (JuliaLang#524) b5de0da Don't fail CI if codecov upload fails. (JuliaLang#525) 78dde4c cast to Float64 directly instead of using float (JuliaLang#521) a5e95ec CI: Add Apple Silicon (macOS aarch64) to the CI matrix (JuliaLang#505) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this issue
Jul 12, 2024
…aLang#54406) Stdlib: SparseArrays URL: https://github.com/JuliaSparse/SparseArrays.jl.git Stdlib branch: main Julia branch: master Old commit: cb602d7 New commit: a09f90b Julia version: 1.12.0-DEV SparseArrays version: 1.12.0 Bump invoked by: @dkarrasch Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl) Diff: JuliaSparse/SparseArrays.jl@cb602d7...a09f90b ``` $ git log --oneline cb602d7..a09f90b a09f90b Adjust matvec and matmatmul! to new internal LinAlg interface (JuliaLang#519) 3b30333 ci: run aqua test as a standalone ci job (JuliaLang#537) df0a154 Add versioned Manifest files to .gitignore (JuliaLang#534) 4606755 Extend `copytrito!` for a sparse source (JuliaLang#533) 33fbc75 SparseMatrixCSC constructor with a Tuple of Integers (JuliaLang#523) 08d6ae1 CI: don't run `threads` tests in Windows GHA CI (attempt 2) (JuliaLang#530) 7408e4b Revert "Don't fail CI if codecov upload fails." (JuliaLang#527) 287e406 Bump julia-actions/setup-julia from 1 to 2 (JuliaLang#524) b5de0da Don't fail CI if codecov upload fails. (JuliaLang#525) 78dde4c cast to Float64 directly instead of using float (JuliaLang#521) a5e95ec CI: Add Apple Silicon (macOS aarch64) to the CI matrix (JuliaLang#505) ``` Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
commit 47cdfde
julia> load("bigint.jl")
julia> BigInt("5.0")
Illegal instruction: 4
-- Crashes
julia> BigInt("asgasggas")
-- Hangs
The text was updated successfully, but these errors were encountered: