Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: remove the export for Base.require #12040

Closed
wants to merge 1 commit into from
Closed

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Jul 6, 2015

this is in preparation for also removing require(::String) during the incremental compilation work (#8745). otherwise it is confusing to the system whether or not it should be using precompiled versions to satisfy this function.

based on a quick grep of my local packages, they should generally have been doing one of (a) not calling require at all (b) using import X instead or (c) using conditional modules or (d) using import followed by a relative using statement.

also, it's nice to actually be eliminating one of the include/require/using/import set.

this is in preparation for removing require(::String) during incremental compilation work
@vtjnash vtjnash added the breaking This change will break code label Jul 6, 2015
@ssfrr
Copy link
Contributor

ssfrr commented Jul 6, 2015

also, it's nice to actually be eliminating one of the include/require/using/import set.

👍 👍

@timholy
Copy link
Member

timholy commented Jul 6, 2015

👍, but can we please do this via a deprecation warning?

@mlubin
Copy link
Member

mlubin commented Jul 7, 2015

Yes, please add a deprecation

@IainNZ
Copy link
Member

IainNZ commented Jul 7, 2015

OTOH, I'm not sure there is a "legitimate" usage of require on 0.3 code, and it should (I think) be easy to fix (that is, no harder than other things we've muddled with). So if having require still around but deprecated is a blocker for something for 0.4 (like package precomp), I don't think we should feel bad for making it a breaking change.

@JeffBezanson
Copy link
Member

Yes, let's just deprecate the function.

@timholy
Copy link
Member

timholy commented Jul 15, 2015

One thing to check: programmatic usage of require in JLD, where the module that needs to be included is encoded as a string in an HDF5 file. What is the recommended way forward here?

@vtjnash vtjnash closed this Jul 18, 2015
@vtjnash vtjnash deleted the jn/not_required branch July 18, 2015 06:45
@vtjnash
Copy link
Member Author

vtjnash commented Jul 18, 2015

merged in #8745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This change will break code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants