Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use NTuple as the representation of a CartesianIndex #12090

Merged
merged 1 commit into from
Jul 10, 2015

Conversation

JeffBezanson
Copy link
Sponsor Member

cc @timholy @mbauman @Jutho
What should I run to make sure there are no performance regressions here?

@timholy
Copy link
Sponsor Member

timholy commented Jul 9, 2015

👍. Use the new perf/array tests.

@Jutho
Copy link
Contributor

Jutho commented Jul 10, 2015

+1

@JeffBezanson
Copy link
Sponsor Member Author

Great, ran the tests, examined results with DataFrames, looks good.

JeffBezanson added a commit that referenced this pull request Jul 10, 2015
use NTuple as the representation of a CartesianIndex
@JeffBezanson JeffBezanson merged commit 9ba9130 into master Jul 10, 2015
@JeffBezanson JeffBezanson deleted the jb/cartesiantuple branch July 10, 2015 17:12
@mbauman
Copy link
Sponsor Member

mbauman commented Jul 10, 2015

Awesome.

@mbauman
Copy link
Sponsor Member

mbauman commented Jul 28, 2015

Bonus 🍰 for speeding up scalar SubArray indexing of small arrays by 6-8x.

@timholy
Copy link
Sponsor Member

timholy commented Jul 28, 2015

I don't really understand how that's possible, but I'll take it! (An NTuple shouldn't be better than a custom immutable.)

Overall I have the sense that the loss of regular perf testing means that we've kind of been bouncing around.

@IainNZ
Copy link
Member

IainNZ commented Jul 28, 2015

AFAIK a new machine has been ordered that we should be able to use for performance testing, so I'm hoping we can grind out (or at least identify) perf regressions before 0.4.0

@ScottPJones
Copy link
Contributor

When will you get this new machine? (would that also be the machine for running PackageEvaluator?)
I'd be happy to do nightly runs on my MacPro, if that would help, until you get it (it's not in use at night anyway)

@jakebolewski
Copy link
Member

Realistically I think end of August would be the soonest we can hope for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants