-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use NTuple as the representation of a CartesianIndex #12090
Conversation
👍. Use the new |
+1 |
Great, ran the tests, examined results with DataFrames, looks good. |
use NTuple as the representation of a CartesianIndex
Awesome. |
Bonus 🍰 for speeding up scalar SubArray indexing of small arrays by 6-8x. |
I don't really understand how that's possible, but I'll take it! (An Overall I have the sense that the loss of regular perf testing means that we've kind of been bouncing around. |
AFAIK a new machine has been ordered that we should be able to use for performance testing, so I'm hoping we can grind out (or at least identify) perf regressions before 0.4.0 |
When will you get this new machine? (would that also be the machine for running PackageEvaluator?) |
Realistically I think end of August would be the soonest we can hope for. |
cc @timholy @mbauman @Jutho
What should I run to make sure there are no performance regressions here?